Better define sigstores purpose #52
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Luke Hinds <lhinds@redhat.com>
dlorenc
approved these changes
May 6, 2021
mtrmac
pushed a commit
to mtrmac/sigstore
that referenced
this pull request
Mar 10, 2023
* Switch from ed25519 to ecdsa ed25519 hasn't yet been approved and won't work with most KMS systems, so we need to use ecdsa until it will. I chose the P521 elliptic curve because it is the most secure one available, although I believe the tradeoff is larger keys. It might be worth it to choose a different curve if we want people to be able to pass in public keys via command line. Signed-off-by: Priya Wadhwa <priyawadhwa@google.com> * Use pointer for pubilc key since rekor expects that Signed-off-by: Priya Wadhwa <priyawadhwa@google.com> * Hash payload before using SignASN1 or VerifyASN1 Signed-off-by: Priya Wadhwa <priyawadhwa@google.com> * use pointer Signed-off-by: Priya Wadhwa <priyawadhwa@google.com> * Switch to P256 curve so that this will work with KMS's Signed-off-by: Priya Wadhwa <priyawadhwa@google.com>
mtrmac
pushed a commit
to mtrmac/sigstore
that referenced
this pull request
Mar 10, 2023
* Switch from ed25519 to ecdsa ed25519 hasn't yet been approved and won't work with most KMS systems, so we need to use ecdsa until it will. I chose the P521 elliptic curve because it is the most secure one available, although I believe the tradeoff is larger keys. It might be worth it to choose a different curve if we want people to be able to pass in public keys via command line. Signed-off-by: Priya Wadhwa <priyawadhwa@google.com> * Use pointer for pubilc key since rekor expects that Signed-off-by: Priya Wadhwa <priyawadhwa@google.com> * Hash payload before using SignASN1 or VerifyASN1 Signed-off-by: Priya Wadhwa <priyawadhwa@google.com> * use pointer Signed-off-by: Priya Wadhwa <priyawadhwa@google.com> * Switch to P256 curve so that this will work with KMS's Signed-off-by: Priya Wadhwa <priyawadhwa@google.com> Signed-off-by: Dan Lorenc <dlorenc@google.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Luke Hinds lhinds@redhat.com