Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

oauthflow: Fix recursive call for GetOutput. #527

Merged
merged 1 commit into from
Jun 24, 2022

Conversation

wlynch
Copy link
Member

@wlynch wlynch commented Jun 23, 2022

Summary

Also adds basic tests to make sure this works.

Signed-off-by: Billy Lynch billy@chainguard.dev

Ticket Link

Release Note

Fixes GetOutput infinite recursion behavior for interactive oauthflow.

@wlynch wlynch force-pushed the tty-recurse branch 2 times, most recently from a8c5730 to dc5b7e9 Compare June 23, 2022 17:22
Also adds basic IO tests to make sure this works.

Signed-off-by: Billy Lynch <billy@chainguard.dev>
@dlorenc dlorenc merged commit 132318a into sigstore:main Jun 24, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants