Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Migrate to go 1.18 for Fuzzing #592

Merged
merged 2 commits into from
Aug 9, 2022
Merged

Migrate to go 1.18 for Fuzzing #592

merged 2 commits into from
Aug 9, 2022

Conversation

naveensrinivasan
Copy link
Contributor

  • Migrating to go 1.18 for Fuzzing

Signed-off-by: naveensrinivasan 172697+naveensrinivasan@users.noreply.github.com

@naveensrinivasan naveensrinivasan changed the title Migrate to go 1.18 for Fuzzing WIP- Migrate to go 1.18 for Fuzzing Aug 2, 2022
@naveensrinivasan
Copy link
Contributor Author

naveensrinivasan commented Aug 2, 2022 •
edited

@AdamKorcz Would you be able to provide some feedback?

edit:- Especially with respect to running in ossfuzz

@naveensrinivasan
Migrate to go 1.18 for Fuzzing
ff1148f 
- Migrating to go 1.18 for Fuzzing

Signed-off-by: naveensrinivasan <172697+naveensrinivasan@users.noreply.github.com>
@naveensrinivasan
Copy link
Contributor Author

@oliverchang Could you please review it? I also wanted to ensure this will work with https://github.com/google/oss-fuzz/tree/master/projects/sigstore

@haydentherapper
Copy link
Contributor

@jonathanmetzman Is there any benefit to changing to this?

@AdamKorcz
Copy link

@AdamKorcz Would you be able to provide some feedback?

edit:- Especially with respect to running in ossfuzz

Will do.

@AdamKorcz
Copy link

AdamKorcz commented Aug 5, 2022 •
edited

@jonathanmetzman Is there any benefit to changing to this?

From the OSS-Fuzz side atm - no. From the perspective of the sigstore contributors - yes, because it will be easier to run the fuzzers locally.
Note that go-fuzz will most likely cease maintenance as Go 1.18 fuzzing matures, so long term it is the right way to go.

@naveensrinivasan naveensrinivasan marked this pull request as ready for review August 6, 2022 13:23
@naveensrinivasan naveensrinivasan changed the title WIP- Migrate to go 1.18 for Fuzzing Migrate to go 1.18 for Fuzzing Aug 6, 2022
bobcallaway
bobcallaway reviewed Aug 8, 2022
View reviewed changes
Copy link
Member

@bobcallaway bobcallaway left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm minus incorrect copyright years

test/fuzz/dsse/fuzz_test.go Outdated Show resolved Hide resolved
test/fuzz/pem/fuzzcert_test.go Outdated Show resolved Hide resolved
test/fuzz/signature/fuzz_signature_test.go Outdated Show resolved Hide resolved
@naveensrinivasan
Moving the rest of the fuzz to go 1.18
0bd07bd 
Signed-off-by: naveensrinivasan <172697+naveensrinivasan@users.noreply.github.com>
bobcallaway
bobcallaway approved these changes Aug 8, 2022
View reviewed changes
Copy link
Member

@bobcallaway bobcallaway left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm, thanks!

@dlorenc dlorenc merged commit 317be3d into sigstore:main Aug 9, 2022
@bobcallaway bobcallaway mentioned this pull request Aug 10, 2022
Closed
mtrmac pushed a commit to mtrmac/sigstore that referenced this pull request Mar 10, 2023
Set the correct predicate type/URI for each supported predicate type. (…
b41d57f 
…sigstore#592)

Signed-off-by: Dan Lorenc <dlorenc@google.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bobcallaway bobcallaway bobcallaway approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@naveensrinivasan @haydentherapper @AdamKorcz @bobcallaway @dlorenc