Add a more friendly error in pubkey failure #623
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rikatz
force-pushed
the
friendly-pubkey-error
branch
2 times, most recently
from
0d018ca
to
036b466
Compare
Signed-off-by: Ricardo Katz <ricardo.katz@gmail.com>
rikatz
force-pushed
the
friendly-pubkey-error
branch
from
036b466
to
8951173
Compare
dlorenc
approved these changes
Aug 15, 2022
mtrmac
pushed a commit
to mtrmac/sigstore
that referenced
this pull request
Mar 10, 2023
…tore#623) * Make sure generate-key-pair doesn't overwrite key-pair by mistake by replicating ssh-keygen behaviour. Also create public key with 0644 permission. Signed-off-by: Pradeep Chhetri <pradeepchhetri4444@gmail.com> * Fix lint errors Signed-off-by: Pradeep Chhetri <pradeepchhetri4444@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Closes #622
When passing a wrong public key to the verify function, it will return an unfriendly error. Instead we can just let users know they are passing the wrong public key format
Release Note
Return a friendly error when an invalid key format is passed
Documentation
No change in docs