Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Package descriptions for all TODOs #685

Merged
merged 1 commit into from
Sep 13, 2022
Merged

Package descriptions for all TODOs #685

merged 1 commit into from
Sep 13, 2022

Conversation

haydentherapper
Copy link
Contributor

Signed-off-by: Hayden Blauzvern hblauzvern@google.com

Summary

Release Note

Documentation

@haydentherapper
Package descriptions for all TODOs
9b6567b 
Signed-off-by: Hayden Blauzvern <hblauzvern@google.com>
cpanato
cpanato approved these changes Sep 13, 2022
View reviewed changes
Copy link
Member

@cpanato cpanato left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thank you!

@cpanato cpanato merged commit fe89132 into sigstore:main Sep 13, 2022
mtrmac pushed a commit to mtrmac/sigstore that referenced this pull request Mar 10, 2023
@mattmoor
Enable errorlint checks. (sigstore#685)
12b1d8d 
This mainly enables (and fixes) the `errorlint` checks.

This also fixes a handful of other things I noticed as I was passing through:
 * `fmt.Errorf` without formatting -> `errors.New`
 * `'%s'` -> `%q`

Signed-off-by: Matt Moore <mattomata@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cpanato cpanato cpanato approved these changes

@asraa asraa asraa approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@haydentherapper @cpanato @asraa