tuf: fix on-disk cache when writing targets in subfolders #729
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Asra Ali <asraa@google.com>
|
To confirm, did you test the following after patching:
|
| if err := os.MkdirAll(d.base, 0o700); err != nil { | ||
|
|
||
| fp := filepath.FromSlash(filepath.Join(d.base, p)) | ||
| if err := os.MkdirAll(filepath.Dir(fp), 0o700); err != nil { |
There was a problem hiding this comment.
Silly question, what if the file exists but with different permissions?
There was a problem hiding this comment.
I think that's a valid cause of "your cache is corrupt" then, if you were manipulating it in a weird way.
There was a problem hiding this comment.
(or if hte question is: what practically happens? os.mkdirall won't do anything if it currently exists. if there were no write perms on it then later, then you'd fail on not being able to write to it: which I think is a corrupt cache)
haydentherapper
approved these changes
Oct 6, 2022
|
Yes!
|
|
Possibly related prober failure, investigating now - #729 |
|
Unrelated! Fixing issue |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Asra Ali asraa@google.com
Added a test, patched
cosignlocally, and can confirm this now works correctly with the v5 root changes.Note: no old clients will break from this change. It's forward compatible.
It's in anticipation of a root update that we'll push to a separate repository as to not break clients who are still using this version. Clients won't break until the current repository loses lifetime: in late January next year.
Summary
Release Note
Documentation