AWS KMS Support #74
Merged
AWS KMS Support #74
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This looks awesome! Thanks! |
Signed-off-by: Cody Soyland <cody.soyland@solarwinds.com>
codysoyland
force-pushed
the
aws-kms-support
branch
from
209eda7
to
2cebefe
Compare
bobcallaway
reviewed
Jul 7, 2021
Signed-off-by: Cody Soyland <cody.soyland@solarwinds.com>
codysoyland
commented
Jul 7, 2021
- Fix a few test issues - Resolve linter warnings - Add WithRemoteVerification option - Use https with AWS custom endpoints - Add env var to disable AWS TLS verification Signed-off-by: Cody Soyland <cody.soyland@solarwinds.com>
|
LGTM - will approve once the e2e tests pass |
Signed-off-by: Cody Soyland <cody.soyland@solarwinds.com>
|
Thanks @bobcallaway for your quick reviews! My last patch should fix the e2e test failures. |
Signed-off-by: Cody Soyland <cody.soyland@solarwinds.com>
|
After that last failure, I set up GHA on my fork and realized it wasn't running the e2e-test.sh script, so I updated the GHA config with the localstack settings and got it passing there. It should be good now! 🤞 |
bobcallaway
approved these changes
Jul 9, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This adds AWS as a supported KMS backend.