Use output to save client cert file locally
#79
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 2 commits
July 6, 2021 11:01
Break condition was trying to match an empty array with nil This resulted in no break condition and the error working down to `error during PEM decoding` Instead match on an empty length Signed-off-by: Luke Hinds <lhinds@redhat.com>
Start to user the output flag to allow users to save the Client Cert locally Signed-off-by: Luke Hinds <lhinds@redhat.com>
Signed-off-by: Luke Hinds <lhinds@redhat.com>
bobcallaway
reviewed
Jul 6, 2021
cpanato
reviewed
Jul 6, 2021
| break | ||
| } | ||
| certDer, restBytes := pem.Decode(remaining) | ||
|
|
There was a problem hiding this comment.
nit: maybe the extra line should be in line 53
if len(remaining) == 0 {
break
}
certDer, restBytes := pem.Decode(remaining)
if certDer == nil {
return nil, errors.New("error during PEM decoding")
}
Co-authored-by: Bob Callaway <bobcallaway@users.noreply.github.com>
Co-authored-by: Bob Callaway <bobcallaway@users.noreply.github.com>
Co-authored-by: Bob Callaway <bobcallaway@users.noreply.github.com>
Signed-off-by: Luke Hinds <lhinds@redhat.com>
Signed-off-by: Luke Hinds <lhinds@redhat.com>
|
should be good now @cpanato / @bobcallaway , DCO failure is from accepting bobs commits in the gui. |
bobcallaway
approved these changes
Jul 6, 2021
cpanato
approved these changes
Jul 6, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Use
outputto save client cert file locallyThis PR is based on top of #78