Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update fetch TSA certs script for Tink #111

Merged
merged 1 commit into from
Oct 31, 2022
Merged

Update fetch TSA certs script for Tink #111

merged 1 commit into from
Oct 31, 2022

Conversation

haydentherapper
Copy link
Contributor

@haydentherapper haydentherapper commented Oct 28, 2022 •
edited

  • Update script to support decrypting Tink key
  • Fix missing subject key ID from leaf cert (automatically populated for CA certs)

Signed-off-by: Hayden Blauzvern hblauzvern@google.com

Summary

Release Note

Documentation

@haydentherapper
Update fetch TSA certs script for Tink
1a74de4 
Signed-off-by: Hayden Blauzvern <hblauzvern@google.com>
@haydentherapper haydentherapper requested a review from a team as a code owner October 28, 2022 22:48
@codecov-commenter
Copy link

Codecov Report

Merging #111 (1a74de4) into main (0faebbe) will decrease coverage by 0.07%.
The diff coverage is 66.66%.

@@            Coverage Diff             @@
##             main     #111      +/-   ##
==========================================
- Coverage   50.29%   50.21%   -0.08%     
==========================================
  Files          14       14              
  Lines         682      687       +5     
==========================================
+ Hits          343      345       +2     
- Misses        305      307       +2     
- Partials       34       35       +1
Impacted Files Coverage Δ
pkg/signer/memory.go 62.50% <66.66%> (-1.50%) ⬇️

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

cpanato
cpanato reviewed Oct 31, 2022
View reviewed changes
Copy link
Member

@cpanato cpanato left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nice

LGTM

malancas
malancas approved these changes Oct 31, 2022
View reviewed changes
Copy link
Contributor

@malancas malancas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@haydentherapper haydentherapper merged commit 6896e85 into main Oct 31, 2022
@haydentherapper haydentherapper deleted the update-fetch-tsa-cert branch October 31, 2022 16:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cpanato cpanato cpanato left review comments

@malancas malancas malancas approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@haydentherapper @codecov-commenter @cpanato @malancas