Verify command returns the parsed timestamp #174
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Meredith Lancaster <malancas@github.com>
Signed-off-by: Meredith Lancaster <malancas@github.com>
Signed-off-by: Meredith Lancaster <malancas@github.com>
pkg/verification/verify.go
Outdated
| } | ||
| return fmt.Errorf("error parsing response into Timestamp: %w", err) | ||
| return nil, fmt.Errorf("error parsing response into Timestamp: %w", err) | ||
| } | ||
|
|
||
| // verify the timestamp response signature using the provided certificate pool | ||
| err = verifyTSRWithChain(ts, opts) |
There was a problem hiding this comment.
nit for readability, can you change these to be:
if err := func(); err != nil {
return nil, err
}
Signed-off-by: Meredith Lancaster <malancas@github.com>
haydentherapper
approved these changes
Dec 9, 2022
Codecov Report
@@ Coverage Diff @@
## main #174 +/- ##
==========================================
- Coverage 48.17% 48.03% -0.14%
==========================================
Files 18 18
Lines 1067 1068 +1
==========================================
- Hits 514 513 -1
- Misses 495 497 +2
Partials 58 58
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Meredith Lancaster malancas@github.com
Summary
Closes #169
The
verifyCLI command now returns the parsed timestamp when verification is successful.Release Note
Documentation