Update README with more details #188
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## main #188 +/- ##
==========================================
- Coverage 47.81% 47.77% -0.04%
==========================================
Files 18 18
Lines 1119 1124 +5
==========================================
+ Hits 535 537 +2
- Misses 528 529 +1
- Partials 56 58 +2
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. |
malancas
previously approved these changes
Dec 15, 2022
asraa
reviewed
Dec 16, 2022
| * Fetch a timestamp for that signature (more below in "What to sign") | ||
| * Upload the signature, artifact hash, and certificate to Rekor (hashedrekord record type) | ||
| * Upload the timestamp to Rekor (rfc3161 record type) | ||
| * This step is important because it makes the timestamps publicly auditable |
There was a problem hiding this comment.
In future work, will timestamp-authority handle this itself?
There was a problem hiding this comment.
Someone asked about this awhile ago. My thought was to make this always client-driven, but maybe we make it configurable? What do you think?
Signed-off-by: Hayden B <hblauzvern@google.com>
|
bump for lgtm |
hectorj2f
approved these changes
Dec 19, 2022
cpanato
approved these changes
Dec 20, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This includes a security model and how to do timestamping with Sigstore.
This includes more details on how to operate the TSA in production also.
Fixes #17
Fixes #116
Signed-off-by: Hayden B hblauzvern@google.com
Summary
Release Note
Documentation