Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

upgrade to go 1.20.1 #245

Merged
merged 4 commits into from Mar 1, 2023
Merged

Conversation

cpanato
Copy link
Member

@cpanato cpanato commented Feb 10, 2023

Summary

  • upgrade to go 1.20.1

@cpanato cpanato requested a review from a team as a code owner February 10, 2023 12:27
Copy link
Contributor

@haydentherapper haydentherapper left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you!

@haydentherapper
Copy link
Contributor

Ah, one unit test failure, looks like you need a different way to seed rand?

@haydentherapper
Copy link
Contributor

Oh you probably need to update the expected test results, I guess the new implementation of random doesn't result in a the same deterministic order (which is kinda strange if true?)

@cpanato
Copy link
Member Author

cpanato commented Feb 11, 2023

Ah, one unit test failure, looks like you need a different way to seed rand?

I saw, did not have time yesterday to fix it, will try this weekend

@codecov-commenter
Copy link

codecov-commenter commented Feb 11, 2023

Codecov Report

Merging #245 (36829d7) into main (8110f91) will decrease coverage by 0.14%.
The diff coverage is 28.57%.

@@            Coverage Diff             @@
##             main     #245      +/-   ##
==========================================
- Coverage   52.66%   52.53%   -0.14%     
==========================================
  Files          19       19              
  Lines        1143     1146       +3     
==========================================
  Hits          602      602              
- Misses        483      486       +3     
  Partials       58       58              
Impacted Files Coverage Δ
pkg/ntpmonitor/ntpmonitor.go 62.93% <0.00%> (-1.68%) ⬇️
pkg/ntpmonitor/randomchoice.go 100.00% <100.00%> (ø)

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

@cpanato
Copy link
Member Author

cpanato commented Feb 13, 2023

@haydentherapper let me know if you agree with the rand change. PTAL

@cpanato
Copy link
Member Author

cpanato commented Feb 15, 2023

@haydentherapper PTAL

Copy link
Contributor

@haydentherapper haydentherapper left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@cpanato could you rebase, then the tests should pass?

Signed-off-by: cpanato <ctadeu@gmail.com>
Signed-off-by: cpanato <ctadeu@gmail.com>
Signed-off-by: cpanato <ctadeu@gmail.com>
Signed-off-by: cpanato <ctadeu@gmail.com>
@cpanato cpanato changed the title upgrade to go 1.20 upgrade to go 1.20.1 Mar 1, 2023
@cpanato
Copy link
Member Author

cpanato commented Mar 1, 2023

@haydentherapper done, PTAL

Copy link
Contributor

@haydentherapper haydentherapper left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you!

@haydentherapper haydentherapper merged commit 0ccecd6 into sigstore:main Mar 1, 2023
@cpanato cpanato deleted the upgrade-go-120 branch March 1, 2023 20:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants