Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update sigstore/sigstore dependencies #774

Merged
merged 2 commits into from
Jun 26, 2024

Conversation

malancas
Copy link
Contributor

Summary

Supersedes #773. A few of the workflows on that PR were failing because go mod tidy had to be run. After updating the dependencies, running go mod tidy, and running unit tests with make test, some of the generated restapi and client content was also regenerated.

Release Note

Documentation

Signed-off-by: Meredith Lancaster <malancas@github.com>
Signed-off-by: Meredith Lancaster <malancas@github.com>
@malancas malancas requested a review from a team as a code owner June 26, 2024 12:57
Copy link

codecov bot commented Jun 26, 2024

Codecov Report

Attention: Patch coverage is 10.20408% with 44 lines in your changes missing coverage. Please review.

Project coverage is 45.92%. Comparing base (6fd19b0) to head (716c9cf).
Report is 131 commits behind head on main.

Files Patch % Lines
pkg/generated/client/timestamp/timestamp_client.go 4.00% 24 Missing ⚠️
...nt/timestamp/get_timestamp_cert_chain_responses.go 0.00% 10 Missing ⚠️
...ient/timestamp/get_timestamp_response_responses.go 16.66% 10 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #774      +/-   ##
==========================================
- Coverage   52.85%   45.92%   -6.94%     
==========================================
  Files          20       55      +35     
  Lines        1209     2942    +1733     
==========================================
+ Hits          639     1351     +712     
- Misses        509     1451     +942     
- Partials       61      140      +79     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Member

@cpanato cpanato left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks

@cpanato cpanato merged commit 9414f29 into sigstore:main Jun 26, 2024
8 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants