fix: handle invalid banner header

sigvt · May 26, 2022 · 37ed5f0 · 37ed5f0
1 parent b6decce
commit 37ed5f0
Show file tree

Hide file tree

Showing 2 changed files with 9 additions and 3 deletions.
diff --git a/src/chat/actions/addBannerToLiveChatCommand.ts b/src/chat/actions/addBannerToLiveChatCommand.ts
@@ -10,9 +10,15 @@ export function parseAddBannerToLiveChatCommand(
   // add pinned item
   const bannerRdr = payload["bannerRenderer"]["liveChatBannerRenderer"];
 
+  if (!bannerRdr.header) {
+    throw new Error(
+      "[action required] Invalid banner header: " + JSON.stringify(bannerRdr)
+    );
+  }
+
   if (bannerRdr.header.liveChatBannerHeaderRenderer.icon.iconType !== "KEEP") {
     debugLog(
-      "[action required] unknown icon type (addBannerToLiveChatCommand)",
+      "[action required] Unknown icon type (addBannerToLiveChatCommand)",
       JSON.stringify(bannerRdr.header.liveChatBannerHeaderRenderer.icon)
     );
   }
@@ -40,7 +46,7 @@ export function parseAddBannerToLiveChatCommand(
 
   if (!authorName) {
     debugLog(
-      "[action required] empty authorName at addBannerToLiveChatCommand",
+      "[action required] Empty authorName found at addBannerToLiveChatCommand",
       JSON.stringify(liveChatRdr)
     );
   }

diff --git a/src/interfaces/yt/chat.ts b/src/interfaces/yt/chat.ts
@@ -446,7 +446,7 @@ export interface YTLiveChatBannerRenderer {
   actionId: string;
   targetId: string; // live-chat-banner
   contents: YTLiveChatTextMessageRendererContainer;
-  header: YTLiveChatBannerRendererHeader;
+  header?: YTLiveChatBannerRendererHeader;
   viewerIsCreator: boolean;
 }