Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Drop timsort dependency when dropping Node 10 support #50

Closed
Siilwyn opened this issue May 29, 2018 · 2 comments
Closed

Drop timsort dependency when dropping Node 10 support #50

Siilwyn opened this issue May 29, 2018 · 2 comments

Comments

@Siilwyn
Copy link
Owner

Siilwyn commented May 29, 2018

Timsort is unmaintained and stuck at an unstable (< 1) version. It has open issues mziccard/node-timsort#8 consider:

  • Using native JS sort
  • Lookup alternative module
  • Move sorting code to internal file
@Siilwyn
Copy link
Owner Author

Siilwyn commented Oct 22, 2018

Update, in V8 version 7.0 a fast stable sort has been implemented! Now we wait for the next LTS to implement this. ⏳

@Siilwyn
Copy link
Owner Author

Siilwyn commented Feb 3, 2020

Blocked until Node.js 10 support is dropped in April 2021.

@Siilwyn Siilwyn changed the title Rethink timsort dependency Drop timsort dependency when dropping Node 10 support Feb 6, 2020
@Siilwyn Siilwyn mentioned this issue Oct 5, 2020
Closed
Siilwyn added a commit that referenced this issue Oct 17, 2020
@Siilwyn
Drop Node.js 10 support to enable native array sorting
7e33770 
Closes #50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@Siilwyn