New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

gallopLeft contains an apparently useless conditional #8

Open

pineapplemachine opened this issue Nov 24, 2016 · 0 comments

pineapplemachine commented Nov 24, 2016 •

edited

Loading

https://github.com/mziccard/node-timsort/blob/master/src/timsort.js#L273

It appears that this condition can never be met, and could be removed.

Same goes for lines 291, 352, and 374.

edit: Unless this is intended to guard against integer overflow in the case of very large inputs?

Siilwyn mentioned this issue

Drop timsort dependency when dropping Node 10 support Siilwyn/css-declaration-sorter#50

Closed

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment