Enfore tabs as indentation #39
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
SimenB
commented
Sep 20, 2016
| "rules": { | ||
| "indent": [ |
SimenB
commented
Sep 20, 2016
| "space-unary-ops": 2, | ||
| "strict": [2, "global"], | ||
| "space-before-function-paren": [2, "never"], |
SimenB
commented
Sep 20, 2016
| @@ -12,7 +12,7 @@ | |||
| }, | |||
| "scripts": { | |||
| "test": "npm run lint && npm run test-unit", | |||
| "lint": "eslint --ignore-pattern doc/ --ignore-path .gitignore .", | |||
| "lint": "node-version-gte-4 && eslint . || node-version-lt-4", | |||
There was a problem hiding this comment.
doc/ doesn't exist, and nothing in .gitignore contains js files
There was a problem hiding this comment.
Yeah, that's old stuff and should be safe to remove!
SimenB
commented
Sep 20, 2016
| @@ -1,15 +1,8 @@ | |||
| { | |||
| "env": { | |||
| "node": true, | |||
There was a problem hiding this comment.
these were the same as the root one, config inherit up the tree
|
👍 on this, just noticed we had mixed spaces and tabs :s |
|
All changes in source code in this PR was made using |
SimenB
commented
Sep 20, 2016
| trim_trailing_whitespace = true | ||
| insert_final_newline = true | ||
|
|
||
| [package.json] |
There was a problem hiding this comment.
npm rewrites this file all the time, should just keep it as spaces
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Noticed that there's horribly mixed spaces and tabs (most of the spaces come from my PR, but not all).
This enforces tabs using eslint, and adds an editorconfig to help IDEs use it automatically.
The second commit upgrades to latest major of eslint. Breaking is mostly dropping support for node older than 4, which is why I included a dep that checks for the node version