Merge master registries to cluster metrics (#183) #442
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rsnigel
changed the title
Closed
|
Is there anything missing to merge this PR? |
|
Sorry for the delay. I don't think merging the master registry by default is a good idea because the master is usually unlike the workers, so aggregated metrics could be skewed. (For example, the master probably has a tiny amount of heap space compared to workers.) #280 achieves the same goal as this PR via opt-in behavior, but it needs tests. If you're up for writing tests for it, that would be super helpful! (Aside, the company I work at doesn't monitor the cluster master at all. The master does so very little that it's not useful to monitor.) |
|
Closing per above, but happy to discuss further. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes issue #183 by merging the registries configured in the master AggregatorRegistry with the worker registries.
This fixes as well the error that incomplete node cluster metrics are returned, because default metrics collected via
collectDefaultMetricswere missing from the master process.From now on, AggregatorRegistry.setRegistries can be used to configure master process registries as well, that will be merged to the cluster metrics.