Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

cache info not fetched by apollo engine? #23

Closed
mydearxym opened this issue Jan 7, 2019 · 3 comments
Closed

cache info not fetched by apollo engine? #23

mydearxym opened this issue Jan 7, 2019 · 3 comments
Assignees

Comments

@mydearxym
Copy link

mydearxym commented Jan 7, 2019

hello there :)

i setup apollo ltracing then add meta to my schema:

image

but the cache hint is always empty:

image

also the apollo-engine seems not receive the cache info

image

image

Why isn't this caching anything?

@athal7
Copy link
Collaborator

athal7 commented Jan 11, 2019

I just tried to reproduce this in the tests, and also updated the reps to use the version of absinthe and absinthe_plug that are in your referenced implementation repository, however, I'm not able to achieve a test failure. Can you verify that the middleware is being called in your integration? The multiple-definition of the middleware function in your schema.ex seems like it might possibly prevent this code from being called.

@mydearxym
Copy link
Author

@athal7 thanks for the help

The multiple-definition of the middleware function in your schema.ex seems like it might possibly prevent this code from being called.

as you said, this it's the main reason, i changed the middleware order ant it works 🎉 !
image
image

but still a little issue:

this meta style works:
image

this not work:
image

@athal7
Copy link
Collaborator

athal7 commented Jan 12, 2019

That’s great to hear!

It doesn’t look like you have the cache keyword in your second implementation.

I think the readme needs to be updated, since there is not a test case for the implementation suggested there.

athal7 pushed a commit that referenced this issue Jan 14, 2019
* Update packages

* Autoformat

* Add tests for inline syntax, update readme for correct syntax.

Fixes #23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants