Fixed extra border in DataTable + cleanup

sikka-software · Oct 12, 2023 · f0ca467 · f0ca467
1 parent 1aabb8a
commit f0ca467
Show file tree

Hide file tree

Showing 5 changed files with 16 additions and 8 deletions.
diff --git a/.storybook/preview.ts b/.storybook/preview.ts
@@ -16,7 +16,8 @@ const preview: Preview = {
             "Introduction",
             "Cards",
             ["Container"],
-            "Input",
+            "Inputs",
+            "Tables",
             "Loading",
             "Button",
             "Cards",

diff --git a/components/elements/DataTable.tsx b/components/elements/DataTable.tsx
@@ -28,8 +28,6 @@ import { Skeleton } from "./Skeleton";
 import { Button } from "./Button";
 import { cn } from "../util";
 
-
-
 type DataTableProps<DataProps = {}> = {
   direction?: "rtl" | "ltr";
   columns: ColumnDef<DataProps>[];
@@ -168,6 +166,7 @@ export const DataTable = <DataProps extends {}>({
                         let isSortable = header.column.columnDef.meta?.sortable;
                         return (
                           <TableHead
+                            dir={props.direction}
                             condensed={props.condensed}
                             clickable={isSortable}
                             key={header.id}
@@ -193,7 +192,11 @@ export const DataTable = <DataProps extends {}>({
                       data-state={row.getIsSelected() && "selected"}
                     >
                       {row.getVisibleCells().map((cell) => (
-                        <TableCell condensed={props.condensed} key={cell.id}>
+                        <TableCell
+                          dir={props.direction}
+                          condensed={props.condensed}
+                          key={cell.id}
+                        >
                           {flexRender(
                             cell.column.columnDef.cell,
                             cell.getContext()

diff --git a/package.json b/package.json
@@ -1,6 +1,6 @@
 {
   "name": "@sikka/hawa",
-  "version": "0.7.10",
+  "version": "0.7.11",
   "main": "./dist/index.js",
   "types": "./dist/index.d.ts",
   "exports": {

diff --git a/stories/ElementsStories/DataTable.stories.tsx b/stories/ElementsStories/DataTable.stories.tsx
@@ -10,7 +10,7 @@ import { setLocale, t } from "../translations/i18n";
 import { ColumnDef } from "@tanstack/react-table";
 import { useEffect, useState } from "react";
 const meta = {
-  title: "Elements/DataTable",
+  title: "Elements/Tables/Data Table",
   component: DataTable,
   parameters: {
     // layout: "centered",
@@ -426,6 +426,7 @@ const Template = (args: any, globals: any) => {
         defaultSort="share_price"
         columns={companiesColumns}
         // data={[]}
+
         data={companiesData}
         condensed
         direction={locale === "ar" ? "rtl" : "ltr"}

diff --git a/stories/ElementsStories/Table.stories.tsx b/stories/ElementsStories/Table.stories.tsx
@@ -4,7 +4,8 @@ import { ArgsTable, Story, Title } from "@storybook/blocks";
 import { setLocale, t } from "../translations/i18n";
 
 const meta = {
-  title: "Elements/Table",
+  title: "Elements/Tables/Simple Table",
+
   component: Table,
   parameters: {
     // layout: "centered",
@@ -38,7 +39,9 @@ const Template = (args: any, globals: any) => {
         columns={[
           { header: "Project", accessorKey: "project" },
           { header: "Version", accessorKey: "version" },
-          // { header: "Version", accessorKey: "version" },
+          { header: "Version", accessorKey: "version" },
+          { header: "Version", accessorKey: "version" },
+          { header: "Version", accessorKey: "version" },
         ]}
         data={[
           { project: "Hawa", version: "0.4.8" },