Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix/cleanup ydk uneeded files #3

Merged
merged 5 commits into from
Mar 16, 2021

Conversation

shmuelhazan
Copy link
Collaborator

No description provided.

@@ -28,7 +28,7 @@

#include <unordered_map>

#include "entity_lookup.hpp"
// #include "entity_lookup.hpp"

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

forgot to remove?

child_name = module_name + ":" + child_name;
}
}
// if (xml_node->ns->href && xml_node->parent && xml_node->parent->ns->href) {

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

should have been deleted?
is this because we don't support namespaces for non-top-level nodes?

@@ -54,10 +54,10 @@ def print_files(self):
for index, package in enumerate(self.packages):
self._print_module(index, package, size)

self._print_entity_lookup_files(self.packages, self.models_dir)
# self._print_entity_lookup_files(self.packages, self.models_dir)

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

delete? if so we sould also delete the def


# RST documentation
self._print_cpp_rst_toc()
# self._print_cpp_rst_toc()

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

also remove def?

std::string Entity::get_absolute_path() const { return ""; }

const std::string Entity::get_namespace() const { return ""; }
std::string Entity::get_namespace() const { return ""; }

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

didn't you want to return std::string()?

@itzik-solomon itzik-solomon merged commit 45f4d0d into siklu-master Mar 16, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
2 participants