This repository has been archived by the owner on Mar 5, 2018. It is now read-only.
Added lazy for request log methods #5
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dschenkelman
force-pushed
the
lazyLogProps
branch
from
406c927
to
10f0927
Compare
| @@ -31,7 +31,7 @@ function logEvent(ctx, data, request) { | |||
| } else if (ctx.includeData && data.data !== undefined) { | |||
| if (ctx.mergeData) { | |||
| try { | |||
| lodash.assign(obj, data.data); | |||
| obj = lodash.assign(data.data, obj); | |||
There was a problem hiding this comment.
We can't modify data people send into a logging library, it's going to screw up other plugins.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Profiling a node.js app an generating a flame chart for it indicates that some time is spent on the
bindcall that is changed by this PR.Since most requests won't actually need all log leves, lazy execution of the
bindimproves this.