Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix issue where @containerless component won't render properly. #11

Closed
silbinarywolf opened this issue Feb 1, 2019 · 1 comment
Closed
Labels

Comments

@silbinarywolf
Copy link
Owner

The problem
After completing/merging a fix for #9, any components I had that were @containerless no longer rendered correctly.

I know that removing the manual attached()/bind() was the correct thing so I need to investigate other solutions.

For example, maybe instead of doing "compile" on the view beforehand, I can just do "enhance" and be done with it.

silbinarywolf added a commit that referenced this issue Feb 1, 2019
…'t be initialized properly, this breaks the ability to manually call detached() lifecycle methods on the component for the time-being however

Fixes #11
@silbinarywolf
Copy link
Owner Author

I've got a solution for this, though it breaks the ability to manually call detached() lifecycle methods on the component for the time-being however

silbinarywolf added a commit that referenced this issue Feb 1, 2019
…'t be initialized properly, this breaks the ability to manually call detached() lifecycle methods on the component for the time-being however (#12)

Fixes #11
@silbinarywolf-travis
Copy link
Collaborator

🎉 This issue has been resolved in version 0.3.2 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants