-
Notifications
You must be signed in to change notification settings - Fork 4
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Refactor as stand-alone rock #38
Conversation
084b149
to
5ce43c7
Compare
8aebd3e
to
6fc0439
Compare
Testing against old versions of SILE might be pretty tricky. We'd probably have to checkout and build the sources for them directly. I might ditch that and just test on the latest to get v2 of this project spun up with a clear path to iterating on small improvements from there. The v2 series will not be compatible with very old versions anyway, basically you'll need at least v0.14.0 just to play and there isn't much point in not running the latest patches on top of that, so this probably wont' be much of a loss until v0.15.0 comes out. |
I'll probably move ahead with this and work on getting all the moving parts in place for a v2 release to LuaRocks.org. Anybody currently using this is almost certainly doing so with old packages and and old SILE to match. Anybody coming along right now and trying to match it to a new SILE is just going to find everything broken. And on top of that nobody else can iterate on smaller improvements like templates and commands without the overall project layout being fixed up. Even if v2.0.0 isn't perfect it should give a working tool that people can easily improve and contribute to again. Having this on master and even tagged as a release won't break anything for anybody that isn't already broken through age and missmatched versions. |
For testing even prior to v2.0.0 tagging, the Docker image for this should be available as the HEAD build now: $ docker pull ghcr.io/sile-typesetter/fontproof:master
$ alias And also the dev rockspec is available on LuaRocks: $ luarocks install fontproof dev-1 |
After installing the rock I'm able to test the new fontproof on some font existing font projects. Looks like when a .sil test file (which we tend to keep under tests/example.sil in various font project repositories) has something like Other test files give me errors like: What am I missing? What am I doing wrong? I'm just trying It would be ideal to be able to reuse existing .sil documents which have How do I set the family field or the font manager? Isn't the papersize field already defined in the package? One simple example is https://github.com/silnrsi/font-andika-mtihani/blob/master/tests/Latin.sil Thank you for any insights and tips. Also I'm quite happy if fontproof just becomes an in-tree package/class and is bundled inside SILE itself. IMHO there is no big need for it to be a standalone package. Çok teşekkür ederim! |
Closes #37
Not ready for primetime yet, but