Merge pull request #857 from alerque/fix-infinite-loop

fix(frames): Avoid possible infinite loop when looking for a frame
sile-typesetter · Apr 28, 2020 · 2c13d78 · 2c13d78
2 parents 5ceee91 + 157dfc8
commit 2c13d78
Showing 1 changed file with 3 additions and 1 deletion.
diff --git a/core/frame.lua b/core/frame.lua
@@ -246,10 +246,12 @@ SILE.getFrame = function (id)
   if type(id) == "table" then
     SU.error("Passed a table, expected a string", true)
   end
-  local frame
+  local frame, last_attempt
   while not frame do
     frame = SILE.frames[id]
     id = id:gsub("_$", "")
+    if id == last_attempt then break end
+    last_attempt = id
   end
   return frame or SU.warn("Couldn't find frame ID "..id, true)
 end