Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ruby.lua should not set lang=ja #926

Closed
ctrlcctrlv opened this issue Jul 8, 2020 · 4 comments · Fixed by #928
Closed

ruby.lua should not set lang=ja #926

ctrlcctrlv opened this issue Jul 8, 2020 · 4 comments · Fixed by #928
Assignees
Labels
bug Software bug issue

Comments

@ctrlcctrlv
Copy link
Member

ctrlcctrlv commented Jul 8, 2020

It seems strange that ruby.lua does this:

SILE.call("language", { main = "ja" }, {})

I can't think of a legitimate reason to. Even if we assume ruby is only used for 振り仮名🐣 (it isn't!), they already should be using a Japanese class, right?

But ruby is often also used for pinyin, bopomofo, etc:

image

@alerque
Copy link
Member

alerque commented Jul 8, 2020

Sounds reasonable to me, but out of my depth to confirm.

@alerque alerque added the bug Software bug issue label Jul 8, 2020
@simoncozens
Copy link
Member

OK, I see why it calls that - the idea was to do \language[main=ja]{}, loading up Japanese language support to get access to the "zw" (全角 width) unit, but scoping the change of language to the empty block. (Similar to \font[...]{foo} versus \font[..] foo. But it doesn't quite work. I'll fix it.

@alerque
Copy link
Member

alerque commented Jul 8, 2020

If the zw unit is useful across more that just Japanese, perhaps it should be moved somewhere higher up than the language support code?

@simoncozens
Copy link
Member

In theory, maybe? In practice, while there is an extremely useful W3C specification for handling Japanese text, there's not a similar one for handling Chinese text, so I'm not currently in a position to support Chinese typesetting in the same way. If we do have something to share, we'll share it, but not yet.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Software bug issue
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants