Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bibliography changes on authors, editors, publishers, dates #2071

Draft
wants to merge 5 commits into
base: master
Choose a base branch
from

Conversation

Omikhleia
Copy link
Member

@Omikhleia Omikhleia commented Jun 15, 2024

WIP based on #2048

(Nothing definitive, but saving my work in progress)

Closes #2052

@Omikhleia Omikhleia requested a review from alerque as a code owner June 15, 2024 16:55
@Omikhleia Omikhleia marked this pull request as draft June 15, 2024 16:55
@Omikhleia Omikhleia changed the title Bibliography refactor on authors, editors, publishers, dates Bibliography changes on authors, editors, publishers, dates Jun 15, 2024
@@ -1,5 +1,37 @@
local Bibliography = require("packages.bibtex.bibliography")

-- WORKAROUND FIXME
-- We may want fluent strings for all languages, but for now we just use English.
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

See #2074 :
It would be a shame to have all possible date composition rules in our ftl files, while CSL locales have them.
(Which doesn't imply that fluent would necessarily be out of the question -- Just that the input should be a CSL locale, however managed afterwards)

Copy link
Member Author

@Omikhleia Omikhleia Jun 16, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

But also note that CSL styles can override some of the CSL locales.
So proper handling of such rules = CSL locales + CSL styles.

@alerque alerque modified the milestones: v0.15.x, v0.15.5 Jun 27, 2024
@Omikhleia Omikhleia force-pushed the bibliography-author-refactor branch from d274a06 to 3ef0109 Compare June 28, 2024 17:49
@Omikhleia Omikhleia mentioned this pull request Jun 29, 2024
5 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: In Progress
Development

Successfully merging this pull request may close these issues.

Editor and translator names in bibliography are passed as raw text
2 participants