-
Notifications
You must be signed in to change notification settings - Fork 35
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add Lz77Decoder
#60
Add Lz77Decoder
#60
Conversation
I'm having trouble understanding how to use this, given a LZ77-encoded reader/buffer. Also, since you're storing a |
First of all, thank you for checking this PR!
IIUC, LZ77 itself doesn't define serialization (binary) format, so you need to extract a sequence of
Sounds good. Thanks! |
You're welcome, though I didn't check much ^^;
Right, I was still slightly confused after referencing the document for the format I'm parsing (here if you're curious; relevant part is at about line 500, or just search "lz77"). I have a better idea of what I'm working with now, but your API is not obvious to me without documentation (e.g. with what pattern is the decoder created/used? when is At any rate, were you working on an implementation with |
Okay, I tried fiddling with the I could envision an interface that requires the user to specify a function for decoding the LZ77 I realize a lot of this is shaking the cruft off of this code that was extracted from the DEFLATE module, but that's where the fun starts :) Apologies for asking so many questions about the library code, though it is inevitable. |
Thanks for your comments. |
Agreed. And your idea sounds interesting, but, to be honest, there is no motivation to radically enhance the current LZ77 implementation because the current one is sufficient to |
I understand. The functionality is fine for me, I just want to understand your goals for the API in this PR, and how you intend it to be used. It seems like you just want to make a minimal functioning API from code extracted from the |
Sorry for the delayed response.
What I need to do is adding doc comments and unit tests. |
Updated. I'll merge this PR once the CI passes. |
Resolves #59