Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow resetting span start time #8

Merged
merged 1 commit into from
Feb 3, 2020
Merged

Conversation

bobrik
Copy link
Contributor

@bobrik bobrik commented Feb 1, 2020

This is especially useful with futures when you can create a future and a span, but only want to start the span when future is first polled.

This is especially useful with futures when you can
create a future and a span, but only want to start
the span when future is first polled.
@bobrik
Copy link
Contributor Author

bobrik commented Feb 2, 2020

Build failed due to description being deprecated in std::error::Error.

It seems that it's recommended to use to_string() instead, but that would mean error.kind will be equal to error.message. I'm not really sure what's the best way forward here.

Copy link
Owner

@sile sile left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for your PR!
The CI failure isn't relevant to the change introduced by you, so I'll fix it after merging this PR.

@sile sile merged commit b9b7a67 into sile:master Feb 3, 2020
@sile
Copy link
Owner

sile commented Feb 3, 2020

I'm not really sure what's the best way forward here.

I think that it might be good to remove StdErrorLogFieldsBuilder::object() method and bump up the minor version. I don't want to keep using a deprecated method, but it seems meaningless to set Error::to_string() to both of error.kind and error.message field.

@sile
Copy link
Owner

sile commented Feb 3, 2020

Applied the above changes and published v0.4.0.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants