Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implement ExtractFromBinary and InjectToBinary traits #15

Merged
merged 3 commits into from
Mar 29, 2019
Merged

Implement ExtractFromBinary and InjectToBinary traits #15

merged 3 commits into from
Mar 29, 2019

Conversation

matevz
Copy link
Contributor

@matevz matevz commented Mar 19, 2019

I implemented basic ExtractFromBinary and InjectToBinary traits:

Please review and merge.

@codecov-io
Copy link

codecov-io commented Mar 19, 2019

Codecov Report

Merging #15 into master will increase coverage by 6.37%.
The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master      #15      +/-   ##
==========================================
+ Coverage   60.34%   66.72%   +6.37%     
==========================================
  Files           7        7              
  Lines         517      598      +81     
==========================================
+ Hits          312      399      +87     
+ Misses        205      199       -6
Impacted Files Coverage Δ
src/span.rs 82.99% <100%> (+8.79%) ⬆️
src/tracer.rs 77.27% <0%> (+5.05%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update ca53437...3638a82. Read the comment docs.

Copy link
Owner

@sile sile left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for your PR. I reviewed it and have left some comments. Please check them.

src/span.rs Outdated Show resolved Hide resolved
src/thrift/jaeger.rs Outdated Show resolved Hide resolved
src/span.rs Outdated Show resolved Hide resolved
@matevz
Copy link
Contributor Author

matevz commented Mar 28, 2019

Thanks for the review. I addressed the issues.

Copy link
Owner

@sile sile left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Thanks for your contribution.

@sile sile merged commit 742ecdf into sile:master Mar 29, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants