Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: implement Display for ChannelNumber #22

Merged
merged 1 commit into from Apr 3, 2024
Merged

feat: implement Display for ChannelNumber #22

merged 1 commit into from Apr 3, 2024

Conversation

thomaseizinger
Copy link
Contributor

Useful in when logging things which is slightly more convenient than calling .value() everywhere.

@coveralls
Copy link

Pull Request Test Coverage Report for Build 8531637840

Details

  • 0 of 3 (0.0%) changed or added relevant lines in 1 file are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage decreased (-0.06%) to 50.956%
Changes Missing Coverage Covered Lines Changed/Added Lines %
src/rfc5766/attributes.rs 0 3 0.0%
Totals Coverage Status
Change from base Build 6608771710: -0.06%
Covered Lines: 1386
Relevant Lines: 2720
💛 - Coveralls

sile
sile approved these changes Apr 3, 2024
View reviewed changes
Copy link
Owner

@sile sile left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@sile sile merged commit 193a5e5 into sile:master Apr 3, 2024
11 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sile sile sile approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@thomaseizinger @coveralls @sile