-
-
Notifications
You must be signed in to change notification settings - Fork 109
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
show route where net ~ [ prefix+ ]
fails because +
is not encoded
#46
Comments
Hi, there doesn't seems to be much reviewing going here, and I thought maybe the way I've opened PRs sporadically has made it difficult to follow.
I can close all these PRs and rebase the remaining 4 commits to my local master for which to open a new PR, if you think it'll be tidier and easy to review. |
Sorry for the delay in reviewing, I will have a look at these PRs soon. |
@tamihiro Thanks for submitting these patches. Here is a quick review, I'm a bit confused:
|
@zorun Thanks for the reply. First let me answer your questions.
These parsing and printing are pretty much coupled, but I'll see if I can try. Anyway please read on.
Let me put it this way. [o] on the right side of The output of [o] AS numbers on the right side of
The pattern in the last one marked with [x] should not be clickable, and I'm trying to solve it. You can see it here for instance.
Unfortunately not quite.. So.. at this point my PRs have made you confused, for which I'm sorry. Honestly I myself is confused too. |
Thanks for the explanation, new PRs sound good! Make sure to include what you just explained in the commit messages :) |
@zorun it's been a while so I've just thought if there's anything that's still unclear. If there is pls feel free to ask. |
@tamihiro yes, sorry for the delay, I have started reviewing the new PR! |
It seems that some of your PR slipped through the cracks again :( I have merged all of them, thanks again for your perseverance! |
My PR #45 now includes patch 94d0357 for this glitch and related inconsistency in edge shapes of the map.
show route where net ~ [ 1.0.4.0/22+ ] (bgpmap)
inconsistent without patch:
![image](https://user-images.githubusercontent.com/5856531/55470094-ea94e400-5641-11e9-85c5-88c192b10459.png)
consistent with patch:
![image](https://user-images.githubusercontent.com/5856531/55470357-65f69580-5642-11e9-8999-2cf9a3823ebc.png)
The text was updated successfully, but these errors were encountered: