Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

test/test_theft_error: check, don't assign in assert() #48

Closed
wants to merge 1 commit into from
Closed

test/test_theft_error: check, don't assign in assert() #48

wants to merge 1 commit into from

Conversation

codyps
Copy link
Contributor

@codyps codyps commented Jan 16, 2019

Pretty sure this was meant to be a check.

Using -Wparentheses (included in -Wall) emits a diagnostic for this.

@codyps
test/test_theft_error: check, don't assign in assert()
b770a19 
Pretty sure this was meant to be a check.

Using `-Wparentheses` (included in `-Wall`) emits a diagnostic for this.
@silentbicycle
Copy link
Owner

Using -Wparentheses (included in -Wall) emits a diagnostic for this.

With what compiler/version? I'm already building with -Wall, and before every release I build with recent versions of gcc, clang, and also do static analysis with scan-build. It's odd that I haven't gotten a warning for it already.

In any case, good catch. Thanks. This too will be cherry-picked to develop.

@silentbicycle
Copy link
Owner

Closed via cherry-pick to develop.

@codyps codyps deleted the test-theft-error-assert-assign branch January 20, 2019 02:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@codyps @silentbicycle