Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Accented char in file name error with Dropbox #134

Closed
JbIPS opened this issue Dec 1, 2017 · 2 comments
Closed

Accented char in file name error with Dropbox #134

JbIPS opened this issue Dec 1, 2017 · 2 comments
Labels
bug

Comments

@JbIPS
Copy link
Collaborator

JbIPS commented Dec 1, 2017

Due to the filename passed in the header of the request, UTF-8 char are not allowed. When setting the header of the request, we should convert them all to URL-safe chars.

Still interested in fixing it @zurukgit ?
@JbIPS JbIPS added the bug label Dec 1, 2017
@SouroucheB
Copy link

Fixing is my duty dude ! Let me handle that :) !

@JbIPS
Copy link
Collaborator Author

JbIPS commented Dec 5, 2017

How is it going? Did you make any progress? Can I help?

JbIPS added a commit that referenced this issue Dec 7, 2017
@JbIPS
Encode non-ASCII chars in Dropbox headers
fddd277 
Path with non-ASCII char are passed in header, creating an error.
Now we replace all special char with the \uXXXX encoding when stringifying the headers.

Closes #134
@JbIPS JbIPS mentioned this issue Dec 7, 2017
Merged
lexoyo pushed a commit that referenced this issue Dec 10, 2017
@JbIPS @lexoyo
Encode non-ASCII chars in Dropbox headers
55a7691 
Path with non-ASCII char are passed in header, creating an error.
Now we replace all special char with the \uXXXX encoding when stringifying the headers.

Closes #134
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@JbIPS @SouroucheB