Fix segfault in extension's protect #181
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
ping @jpauli |
|
shouldn't you decrement it somewhere too ? |
|
👍 merge it please |
fabpot
added a commit
that referenced
this pull request
Jul 30, 2015
This PR was merged into the 3.0.x-dev branch.
Discussion
----------
Fix segfault in extension's protect
Fixes a segfault in the extension. The function being protected seems to need to have the refcount incremented.
```
php --version
PHP 5.5.9-1ubuntu4.11 (cli) (built: Jul 2 2015 15:23:08)
Copyright (c) 1997-2014 The PHP Group
Zend Engine v2.5.0, Copyright (c) 1998-2014 Zend Technologies
with Zend OPcache v7.0.3, Copyright (c) 1999-2014, by Zend Technologies
with Xdebug v2.2.3, Copyright (c) 2002-2013, by Derick Rethans
```
tests/015.mem
```
==32129== Invalid read of size 1
==32129== at 0x6DDE55: zval_call_destructor (zend_execute_API.c:203)
==32129== by 0x6FBE63: zend_hash_reverse_apply (zend_hash.c:799)
==32129== by 0x6DE290: shutdown_destructors (zend_execute_API.c:217)
==32129== by 0x6EDD23: zend_call_destructors (zend.c:919)
==32129== by 0x68E2A4: php_request_shutdown (main.c:1750)
==32129== by 0x79EF49: do_cli (php_cli.c:1177)
==32129== by 0x461E0F: main (php_cli.c:1378)
==32129== Address 0x77d5b74 is 20 bytes inside a block of size 32 free'd
==32129== at 0x4C2BDEC: free (in /usr/lib/valgrind/vgpreload_memcheck-amd64-linux.so)
==32129== by 0x750C508: pimple_bucket_dtor (pimple.c:490)
==32129== by 0x6FB977: zend_hash_destroy (zend_hash.c:560)
==32129== by 0x750CEE1: pimple_free_object_storage (pimple.c:189)
==32129== by 0x715E3B: zend_objects_store_del_ref_by_handle_ex (zend_objects_API.c:226)
==32129== by 0x715E62: zend_objects_store_del_ref (zend_objects_API.c:178)
==32129== by 0x6DDEBF: _zval_ptr_dtor (zend_variables.h:35)
==32129== by 0x6FA334: zend_hash_apply_deleter (zend_hash.c:650)
==32129== by 0x6FBE78: zend_hash_reverse_apply (zend_hash.c:804)
==32129== by 0x6DE290: shutdown_destructors (zend_execute_API.c:217)
==32129== by 0x6EDD23: zend_call_destructors (zend.c:919)
==32129== by 0x68E2A4: php_request_shutdown (main.c:1750)
==32129==
==32129== Invalid read of size 4
==32129== at 0x6DDE62: zval_call_destructor (zend_execute_API.c:203)
==32129== by 0x6FBE63: zend_hash_reverse_apply (zend_hash.c:799)
==32129== by 0x6DE290: shutdown_destructors (zend_execute_API.c:217)
==32129== by 0x6EDD23: zend_call_destructors (zend.c:919)
==32129== by 0x68E2A4: php_request_shutdown (main.c:1750)
==32129== by 0x79EF49: do_cli (php_cli.c:1177)
==32129== by 0x461E0F: main (php_cli.c:1378)
==32129== Address 0x77d5b70 is 16 bytes inside a block of size 32 free'd
==32129== at 0x4C2BDEC: free (in /usr/lib/valgrind/vgpreload_memcheck-amd64-linux.so)
==32129== by 0x750C508: pimple_bucket_dtor (pimple.c:490)
==32129== by 0x6FB977: zend_hash_destroy (zend_hash.c:560)
==32129== by 0x750CEE1: pimple_free_object_storage (pimple.c:189)
==32129== by 0x715E3B: zend_objects_store_del_ref_by_handle_ex (zend_objects_API.c:226)
==32129== by 0x715E62: zend_objects_store_del_ref (zend_objects_API.c:178)
==32129== by 0x6DDEBF: _zval_ptr_dtor (zend_variables.h:35)
==32129== by 0x6FA334: zend_hash_apply_deleter (zend_hash.c:650)
==32129== by 0x6FBE78: zend_hash_reverse_apply (zend_hash.c:804)
==32129== by 0x6DE290: shutdown_destructors (zend_execute_API.c:217)
==32129== by 0x6EDD23: zend_call_destructors (zend.c:919)
==32129== by 0x68E2A4: php_request_shutdown (main.c:1750)
```
Commits
-------
8476b1f Fix segfault in extension's protect
|
Thanks you @jbboehr |
|
@jpauli what about my comment ? |
|
Refcount is already decremented in destructor, an addref was missing though |
|
I'm guessing this probably fixes #177 and #148 |
|
Yes, same bug |
glensc
added a commit
to pld-linux/php-ext-pimple
that referenced
this pull request
Jul 31, 2015
fixes segfault in extension silexphp/Pimple#181 https://github.com/silexphp/Pimple/issues/177 https://github.com/silexphp/Pimple/issues/148
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes a segfault in the extension. The function being protected seems to need to have the refcount incremented.
tests/015.mem