You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
{{ message }}
This repository has been archived by the owner on Sep 14, 2018. It is now read-only.
On requesting any route in dev, silex responses with:
Twig_Error_Runtime in Template.php line 485:
Method "request" for object "Silex\Application" does not exist in "@WebProfiler/Profiler/base_js.html.twig" at line 208
I think symfony/symfony#14217 broke something, because I updated all dependencies today, before everything worked flawless. Did I missed something?
…tes (stof)
This PR was merged into the 2.6 branch.
Discussion
----------
Avoid using the app global variable in the profiler templates
| Q | A
| ------------- | ---
| Bug fix? | yes
| New feature? | no
| BC breaks? | small one for people overwriting the WebDebugToolbarListener methods
| Deprecations? | no
| Tests pass? | yes
| Fixed tickets | silexphp/Silex-WebProfiler#64
| License | MIT
| Doc PR | n/a
#14217 introduced a usage of the ``app`` global variables in profiler templates, while we previously removed all such usages to avoid the dependency on TwigBundle in these templates.
This keeps them usable outside the fullstack framework (for instance in Silex).
I had to do a small BC break to be able to pass the request in the place where we were not yet injecting the Request in the template.
Commits
-------
415c79e Avoid using the app global variable in the profiler templates
My composer.json:
On requesting any route in dev, silex responses with:
I think symfony/symfony#14217 broke something, because I updated all dependencies today, before everything worked flawless. Did I missed something?
Just as a note: Manually hack twig-cache from:
to
would prevent this issue and of course force
web-profiler-bundle
to v2.6.7 incomposer.json
, too:The text was updated successfully, but these errors were encountered: