Minor optimization in ValidatorServiceProvider

ReflectionClass is only needed if a translator is present. Moving usage of it inside the related conditional means one less object instantiation.
silexphp · Jul 8, 2014 · 1aed8cd · 1aed8cd
1 parent 4f81347
commit 1aed8cd
Showing 1 changed file with 1 addition and 2 deletions.
diff --git a/src/Silex/Provider/ValidatorServiceProvider.php b/src/Silex/Provider/ValidatorServiceProvider.php
@@ -29,9 +29,8 @@ class ValidatorServiceProvider implements ServiceProviderInterface
     public function register(Application $app)
     {
         $app['validator'] = $app->share(function ($app) {
-            $r = new \ReflectionClass('Symfony\Component\Validator\Validator');
-
             if (isset($app['translator'])) {
+                $r = new \ReflectionClass('Symfony\Component\Validator\Validator');
                 $app['translator']->addResource('xliff', dirname($r->getFilename()).'/Resources/translations/validators.'.$app['locale'].'.xlf', $app['locale'], 'validators');
             }