This repository has been archived by the owner on Jul 4, 2018. It is now read-only.
Added factory for RouteCollection, makes subclassing of RouteCollection possible. #1175
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -64,8 +63,12 @@ public function __construct(array $values = array()) | |||
|
|
|||
| $app = $this; | |||
|
|
|||
| $this['routes'] = function () { | |||
| return new RouteCollection(); | |||
| $this['routes_class'] = 'Symfony\\Component\\Routing\\RouteCollection'; | |||
There was a problem hiding this comment.
I would remove this as overriding the routes_factory would do the same. So, it's not really a good extension point.
|
I updated the code and added some tests to cover this new feature as you suggested @fabpot. Do you think the tests provide enough coverage? @stof, this PR does not solve my use case directly, but using it to have |
| use Silex\Api\BootableProviderInterface; | ||
| use Silex\Api\EventListenerProviderInterface; | ||
| use Silex\Api\ControllerProviderInterface; | ||
| use Silex\Provider\RoutingServiceProvider; | ||
| use Silex\Provider\KernelServiceProvider; | ||
| use Symfony\Component\Routing\RouteCollection; |
There was a problem hiding this comment.
This should be reverted back to its original place.
|
@fabpot PR updated. |
lschricke
force-pushed
the
allow-routecollection-subclassing
branch
from
6808670
to
18f253f
Compare
|
I squashed my commits and rebased the PR. |
|
Thank you @lschricke. |
fabpot
added a commit
that referenced
this pull request
Jun 24, 2015
… RouteCollection possible. (lschricke) This PR was merged into the 2.0.x-dev branch. Discussion ---------- Added factory for RouteCollection, makes subclassing of RouteCollection possible. Note: replaces #1174, which was targeting a wrong branch (and where I messed a bit with the commits ;)). -- The aim of this PR is to allow developpers to subclass `Symfony\Component\Routing\RouteCollection` to change some of its behavior. In most of my Silex apps, I figured I don't want the Symfony's `RouteCollection` regular behavior where if you define two routes with the same name (bad copy-paste for instance), the first route added simply gets overriden by the second. Instead, I would like to be able to throw an Exception if that happens. So I've written [a tiny subclass of RouteCollection](https://github.com/lschricke/symfony-strict-route-collection), but to be able to use it (through [a service provider like this](https://github.com/lschricke/silex-strict-route-collection-service-provider) for instance (needs to be updated for Silex 2)), I need to be able to replace `RouteCollection` by my subclass. This PR makes it possible. Thanks! :) Commits ------- 18f253f Added factory for RouteCollection, makes subclassing of RouteCollection possible.
|
And thank you @fabpot and all the contributors for this awesome tool! :) |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Note: replaces #1174, which was targeting a wrong branch (and where I messed a bit with the commits ;)).
The aim of this PR is to allow developpers to subclass
Symfony\Component\Routing\RouteCollectionto change some of its behavior.In most of my Silex apps, I figured I don't want the Symfony's
RouteCollectionregular behavior where if you define two routes with the same name (bad copy-paste for instance), the first route added simply gets overriden by the second. Instead, I would like to be able to throw an Exception if that happens. So I've written a tiny subclass of RouteCollection, but to be able to use it (through a service provider like this for instance (needs to be updated for Silex 2)), I need to be able to replaceRouteCollectionby my subclass. This PR makes it possible.Thanks! :)