Skip to content
This repository has been archived by the owner on Jul 4, 2018. It is now read-only.

added support for the Symfony Security component #356

Merged
merged 6 commits into from Jun 13, 2012
Merged

added support for the Symfony Security component #356

merged 6 commits into from Jun 13, 2012

Conversation

fabpot
Copy link
Member

@fabpot fabpot commented Jun 13, 2012

Some few things are not (yet) configurable, but this extension should cover most common needs and then some more. It is actually as powerful as the support we have in the Symfony full-stack framework.

.. code-block:: json

"require": {
"symfony/security": "2.1.*"
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this note is wrong as you added the Security component as a requirement in the composer.json, not only as a dev requirement

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

which was a mistake.

@davedevelopment
Copy link
Contributor

This is awesome. Not only can I throw away my sketchy implementation, I can see all the things I did wrong! Cheers @fabpot!


* **login_path**: The login path where the user is redirected when he is
accessing a secured area without being authenticated so that he can enter
his credentials;
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm not sure, but this url is also used if a user does not have enough credential for the asked ressource.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@lyrixx not really. If the user is already fully logged (remember_me token), he is simply given a chance to authenticate fully. If the user is already fully logged, he should simply receive a 403 response

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@stof OK, thanks. I think you forgot a "not already fully logged"

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

indeed

fabpot added a commit that referenced this pull request Jun 13, 2012
Commits
-------

1886811 tweaked some docs
6a0f05d tweaked docs
4313458 updated vendors
1286709 moved security to the dev requirements
320a268 updated the changelog
2b711bc added support for the Symfony Security component

Discussion
----------

added support for the Symfony Security component

Some few things are not (yet) configurable, but this extension should cover most common needs and then some more. It is actually as powerful as the support we have in the Symfony full-stack framework.

---------------------------------------------------------------------------

by davedevelopment at 2012-06-13T08:30:42Z

This is awesome. Not only can I throw away my sketchy implementation, I can see all the things I did wrong! Cheers @fabpot!
@fabpot fabpot merged commit 1886811 into master Jun 13, 2012
@lyrixx
Copy link
Contributor

lyrixx commented Jun 13, 2012

nice 🙌

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants