Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Reuse docker image #32

Merged
merged 4 commits into from
Sep 1, 2023
Merged

Reuse docker image #32

merged 4 commits into from
Sep 1, 2023

Conversation

troibe
Copy link
Contributor

@troibe troibe commented Aug 31, 2023

Depends on siliconcompiler/siliconcompiler#1921
The @reuse-docker-image needs to be changed to @main before merging into main.

@troibe troibe requested a review from gadfort August 31, 2023 16:21
gadfort
gadfort requested changes Aug 31, 2023
View reviewed changes
.github/workflows/ci.yml Show resolved Hide resolved
@troibe troibe mentioned this pull request Sep 1, 2023
Merged
@troibe
Copy link
Contributor Author

troibe commented Sep 1, 2023

The @latest-version-docker-image needs to be changed to @main before merging into main.

@troibe
Copy link
Contributor Author

troibe commented Sep 1, 2023

Hope the version thing was actually the issue here...

@troibe troibe requested a review from gadfort September 1, 2023 16:16
@troibe troibe merged commit 7f70521 into main Sep 1, 2023
12 checks passed
@troibe troibe deleted the reuse-docker-image branch September 1, 2023 16:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@gadfort gadfort gadfort approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@troibe @gadfort