Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix: wrong timeout implementation #404

Merged
merged 4 commits into from
Aug 20, 2021
Merged

Fix: wrong timeout implementation #404

merged 4 commits into from
Aug 20, 2021

Conversation

YouYue123
Copy link

Update on top of #316

I did the following changes

  1. Added 2 new APIs for readTimeout and connectTimeout. For Android these 2 are set perspectively. For iOS, in order to keep the interface consistent, I am using readTimeout as the internal value for timeoutInterval.
  2. Updated docs and test cases to cover these 2 new APIs
  3. The original setRequestTimeout API will set both connectTimeout and readTimeout

Let me know if you think any further changes are needed

broglep-work and others added 2 commits March 5, 2020 15:46
@broglep-work
apply timeout correctly on android
6797d2c 
Also set connectTimeout
1. Add connectTimeout getter, setter
4687bad 
2. Add readTimeout getter, setter
3. Modify android and ios part to take from connect and readtimeout
4. update docs
@YouYue123 YouYue123 changed the title Change timeout setting API Timeout API Fix Mar 18, 2021
@silkimen
Copy link
Owner

Thank you @YouYue123, but there are some unresolved conflicting files. Would you please check this?

silkimen
silkimen requested changes Mar 24, 2021
View reviewed changes
test/js-specs.js Outdated Show resolved Hide resolved
test/js-specs.js Outdated Show resolved Hide resolved
test/js-specs.js Outdated Show resolved Hide resolved
test/js-specs.js Outdated Show resolved Hide resolved
www/global-configs.js Outdated Show resolved Hide resolved
www/public-interface.js Show resolved Hide resolved
@silkimen silkimen force-pushed the master branch 3 times, most recently from e8a8d65 to 0ccf64e Compare July 22, 2021 13:40
@silkimen silkimen changed the title Timeout API Fix Fix: wrong timeout implementation Aug 20, 2021
@silkimen silkimen merged commit 6f68aab into silkimen:master Aug 20, 2021
silkimen added a commit that referenced this pull request Aug 20, 2021
@silkimen
fix: compile error in fix #404
1bafe6c
@silkimen silkimen mentioned this pull request Sep 16, 2022
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@silkimen silkimen silkimen requested changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@YouYue123 @silkimen @broglep-work