Catch unanticipated EOFException due to empty stream when redirecting. #501
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ath0mas
reviewed
Feb 14, 2024
| progress.onUpload(totalWritten, totalSize); | ||
| } | ||
| }catch(EOFException e){ | ||
| e.printStackTrace(); | ||
| } |
There was a problem hiding this comment.
Should this also be done in the copy(Reader that follows? given it has a similar while ((read = input.read(buffer)) … loop.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When one wants to disable followRedirect, sometimes the InputStream will throw an EOFException due to there being no content in the response body. It is undesired for this to result in an error returned to Cordova, as the end user would just want to be able to read the Location header anyway (and follow it if necessary).