Add ignored tests for bug #52

Also enable filter for SIL.BuildTasks.
sillsdev · Aug 2, 2021 · db6802f · db6802f
1 parent a9100e1
commit db6802f
Show file tree

Hide file tree

Showing 2 changed files with 126 additions and 1 deletion.
diff --git a/SIL.BuildTasks/SIL.BuildTasks.csproj b/SIL.BuildTasks/SIL.BuildTasks.csproj
@@ -24,6 +24,7 @@ See full changelog at https://github.com/sillsdev/SIL.BuildTasks/blob/master/CHA
     <EmbedUntrackedSources>true</EmbedUntrackedSources>
     <PublishRepositoryUrl>true</PublishRepositoryUrl>
     <UseFullSemVerForNuGet>false</UseFullSemVerForNuGet>
+    <FilterEntries>true</FilterEntries>
   </PropertyGroup>
   <ItemGroup>
     <Reference Include="Microsoft.Build.Framework" />

diff --git a/SIL.ReleaseTasks.Tests/SetReleaseNotesPropertyTests.cs b/SIL.ReleaseTasks.Tests/SetReleaseNotesPropertyTests.cs
@@ -873,6 +873,130 @@ public void FilterEntriesWithoutPackage()
 "));
 
 		}
+
+		[Test]
+		[Ignore("issue #52")]
+		public void FilterEntries_UnreleasedWithComment()
+		{
+			// Setup
+			var sut = new SetReleaseNotesProperty();
+			sut.BuildEngine = new MockEngine();
+			_tempFile = Path.GetTempFileName();
+			sut.FilterEntries = true;
+			sut.PackageId = "MyProject1";
+			sut.ChangelogFile = _tempFile;
+
+			File.WriteAllText(_tempFile, @"
+# Change Log
+
+<!-- comment
+-->
+
+## [Unreleased]
+
+### Added
+
+- [MyProject1] Add 'DoSomething()' method to 'Foo'
+- 'ReadMe.md' Lorem ipsum
+
+## [2.4.0] - 2021-01-22
+");
+
+			// Exercise
+			var result = sut.Execute();
+
+			// Verify
+			Assert.That(result, Is.True);
+			Assert.That(sut.Value, Is.EqualTo(@"Changes since version 2.4.0
+
+Added:
+- Add 'DoSomething()' method to 'Foo'
+- 'ReadMe.md' Lorem ipsum
+"));
+		}
+
+		[Test]
+		[Ignore("issue #52")]
+		public void FilterEntries_ReleasedWithComment()
+		{
+			// Setup
+			var sut = new SetReleaseNotesProperty();
+			sut.BuildEngine = new MockEngine();
+			_tempFile = Path.GetTempFileName();
+			sut.FilterEntries = true;
+			sut.PackageId = "MyProject1";
+			sut.ChangelogFile = _tempFile;
+
+			File.WriteAllText(_tempFile, @"
+# Change Log
+
+<!-- comment
+-->
+
+## [Unreleased]
+
+## [2.4.0] - 2021-01-22
+
+### Added
+
+- [MyProject1] Add 'DoSomething()' method to 'Foo'
+- 'ReadMe.md' Lorem ipsum
+
+## [2.3.0] - 2021-01-21
+");
+
+			// Exercise
+			var result = sut.Execute();
+
+			// Verify
+			Assert.That(result, Is.True);
+			Assert.That(sut.Value, Is.EqualTo(@"Changes since version 2.3.0
+
+Added:
+- Add 'DoSomething()' method to 'Foo'
+- 'ReadMe.md' Lorem ipsum
+"));
+		}
+
+		[Test]
+		public void FilterEntries_UnreleasedUnfilteredWithComment()
+		{
+			// Setup
+			var sut = new SetReleaseNotesProperty();
+			sut.BuildEngine = new MockEngine();
+			_tempFile = Path.GetTempFileName();
+			sut.FilterEntries = false;
+			sut.PackageId = "MyProject1";
+			sut.ChangelogFile = _tempFile;
+
+			File.WriteAllText(_tempFile, @"
+# Change Log
+
+<!-- comment
+-->
+
+## [Unreleased]
+
+### Added
+
+- [MyProject1] Add 'DoSomething()' method to 'Foo'
+- 'ReadMe.md' Lorem ipsum
+
+## [2.4.0] - 2021-01-22
+");
+
+			// Exercise
+			var result = sut.Execute();
+
+			// Verify
+			Assert.That(result, Is.True);
+			Assert.That(sut.Value, Is.EqualTo(@"Changes since version 2.4.0
+
+Added:
+- [MyProject1] Add 'DoSomething()' method to 'Foo'
+- 'ReadMe.md' Lorem ipsum
+"));
+		}
+
 	}
-
 }