Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add filter option #51

Merged
merged 4 commits into from
Aug 2, 2021
Merged

add filter option #51

merged 4 commits into from
Aug 2, 2021

Conversation

elisunger
Copy link
Contributor

No description provided.

Copy link
Member

@ermshiperete ermshiperete left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good in general. A few comments and suggestions. I also found two scenarios where things don't yet work quite correct.

Also, can you please mention the issue number (#48) in the commit message.

The bottom three items of the ToDo list in #48 are still missing.

SIL.ReleaseTasks.Tests/SetReleaseNotesPropertyTests.cs Outdated Show resolved Hide resolved
SIL.ReleaseTasks/SetReleaseNotesProperty.cs Outdated Show resolved Hide resolved
SIL.ReleaseTasks/SetReleaseNotesProperty.cs Outdated Show resolved Hide resolved
SIL.ReleaseTasks/SetReleaseNotesProperty.cs Outdated Show resolved Hide resolved
SIL.ReleaseTasks/SetReleaseNotesProperty.cs Outdated Show resolved Hide resolved
SIL.ReleaseTasks/SetReleaseNotesProperty.cs Outdated Show resolved Hide resolved
SIL.ReleaseTasks/SetReleaseNotesProperty.cs Outdated Show resolved Hide resolved
SIL.ReleaseTasks.Tests/SetReleaseNotesPropertyTests.cs Outdated Show resolved Hide resolved
SIL.ReleaseTasks/SetReleaseNotesProperty.cs Show resolved Hide resolved
Copy link
Member

@ermshiperete ermshiperete left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We're getting closer! Thanks!

A few small nit-picks. Feel free to use GitHub's "Commit suggestion" or "Add suggestion to batch" feature if you like.

SIL.ReleaseTasks.md needs a bit more work. It was probably not clear what I meant when I asked to update the documentation; I hope it's clearer now.

Also, can you please add a line to the Unreleased section of CHANGELOG.md, something like:

## [Unreleased]

### Added

- [SIL.ReleaseTasks] Added filter option for project-specific entries (#48)

### Fixed
...

Documentation/SIL.ReleaseTasks.md Outdated Show resolved Hide resolved
SIL.ReleaseTasks/SetReleaseNotesProperty.cs Outdated Show resolved Hide resolved
SIL.ReleaseTasks/SetReleaseNotesProperty.cs Outdated Show resolved Hide resolved
SIL.ReleaseTasks/SetReleaseNotesProperty.cs Outdated Show resolved Hide resolved
SIL.ReleaseTasks/SetReleaseNotesProperty.cs Outdated Show resolved Hide resolved
SIL.ReleaseTasks/SetReleaseNotesProperty.cs Outdated Show resolved Hide resolved
SIL.ReleaseTasks/SetReleaseNotesProperty.cs Outdated Show resolved Hide resolved
SIL.ReleaseTasks/SetReleaseNotesProperty.cs Outdated Show resolved Hide resolved
SIL.ReleaseTasks/SetReleaseNotesProperty.cs Outdated Show resolved Hide resolved
SIL.ReleaseTasks/SetReleaseNotesProperty.cs Outdated Show resolved Hide resolved
Copy link
Member

@ermshiperete ermshiperete left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

Documentation/SIL.ReleaseTasks.md Outdated Show resolved Hide resolved
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants