Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

FileUpdate: do not fail if literal ReplacementText is found #64

Conversation

tombogle
Copy link
Contributor

@tombogle tombogle commented Aug 11, 2023

Fixed regression caused by running FileUpdate on same file with same parameters (in multiple build steps). FileUpdate should not fail if literal ReplacementText is found.


This change is Reviewable

…parameters (in multiple build steps). FileUpdate should not fail if literal ReplacementText is found.
@tombogle tombogle added the bug Something isn't working label Aug 11, 2023
@tombogle tombogle self-assigned this Aug 11, 2023
@github-actions
Copy link

Test Results

193 tests  +2   192 ✔️ +2   11s ⏱️ -3s
  22 suites +1       1 💤 ±0 
    2 files   ±0       0 ±0 

Results for commit a0e9cea. ± Comparison against base commit 3d20b9a.

Copy link
Contributor

@andrew-polk andrew-polk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewed 2 of 2 files at r1, all commit messages.
Reviewable status: :shipit: complete! all files reviewed, all discussions resolved (waiting on @ermshiperete)

@tombogle tombogle merged commit de9a3fc into master Aug 11, 2023
6 checks passed
@tombogle tombogle deleted the FileUpdate-should-not-fail-if-literal-replacementtext-is-found branch August 11, 2023 15:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants