Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Replace deprecated Hidden component with useMediaQuery hook #3246

Open
wants to merge 5 commits into
base: master
Choose a base branch
from

Conversation

imnasnainaec
Copy link
Collaborator

@imnasnainaec imnasnainaec commented Jul 10, 2024

Resolves #3220

The following pages/components have layout changes at various window widths. A review of this pr confirms that the changes are visually the same in this branch and on QA.

  • Landing Page
  • App Bar (best tested with a long project name and a long username)
  • Project Screen
  • Project Settings (just the tabs, not the individual settings)
  • Tree View

Transitions can occur at 600px, 900px, 1200px, 1536px window widths.


This change is Reviewable

@imnasnainaec imnasnainaec added frontend maintenance Issue that makes it difficult to maintain the software or to upgrade installations post-release. labels Jul 10, 2024
@imnasnainaec imnasnainaec self-assigned this Jul 10, 2024
Copy link

codecov bot commented Jul 10, 2024

Codecov Report

Attention: Patch coverage is 83.33333% with 3 lines in your changes missing coverage. Please review.

Project coverage is 74.96%. Comparing base (b06fac6) to head (d5f2323).

Files Patch % Lines
src/components/AppBar/ProjectButtons.tsx 75.00% 0 Missing and 1 partial ⚠️
src/components/AppBar/UserMenu.tsx 66.66% 0 Missing and 1 partial ⚠️
src/components/LandingPage/index.tsx 50.00% 0 Missing and 1 partial ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master    #3246      +/-   ##
==========================================
+ Coverage   74.82%   74.96%   +0.13%     
==========================================
  Files         277      277              
  Lines       10637    10655      +18     
  Branches     1278     1281       +3     
==========================================
+ Hits         7959     7987      +28     
+ Misses       2314     2302      -12     
- Partials      364      366       +2     
Flag Coverage Δ
backend 84.04% <ø> (+0.02%) ⬆️
frontend 66.96% <83.33%> (+0.26%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@imnasnainaec imnasnainaec marked this pull request as ready for review July 12, 2024 12:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
frontend maintenance Issue that makes it difficult to maintain the software or to upgrade installations post-release.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Replace deprecated Hidden component
1 participant