Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Superadmins can create/update records outside of their organization #281

Merged
merged 1 commit into from Nov 14, 2018

Conversation

davidmoore1
Copy link
Contributor

No description provided.

@davidmoore1 davidmoore1 changed the title Superusers can create/update records outside of their organization Superadmins can create/update records outside of their organization Nov 13, 2018
Copy link
Member

@chrisvire chrisvire left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@@ -58,6 +64,15 @@ protected void ValidateOrganizationHeader(int initialOrganizationId, string obje
}
}
}
protected bool IsCurrentUserSuperAdmin()
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

would it be worth it to put this closer to where we get the current user?
or maybe have another service that abstracts this away?
we may need it in general, or helpers like it for more fine-grain permission controls.

I'm totes fine with that getting thrown in the backlog though, to be abstracted when needed.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Added backlog item 109 to refactor this once it became clearer who all would need it and whether other generalization needed to be added.

@davidmoore1 davidmoore1 merged commit 1ae723e into master Nov 14, 2018
@davidmoore1 davidmoore1 deleted the feature/superadmin-validation branch November 14, 2018 13:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants