Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

FFMPEG not properly downloading in application #11

Closed
megahirt opened this issue Feb 21, 2020 · 3 comments
Closed

FFMPEG not properly downloading in application #11

megahirt opened this issue Feb 21, 2020 · 3 comments
Labels
bug Something isn't working
Milestone

Comments

@megahirt
Copy link
Collaborator

image
This happened on JB's computer - I could not repro on my computer (worked fine). We are both Windows 10 and latest HearThis and Bible Karaoke.

@megahirt megahirt added the bug Something isn't working label Mar 2, 2020
@megahirt
Copy link
Collaborator Author

megahirt commented Mar 5, 2020

From W:

Seems like BK is creating the binaries folder after clicking Make My
Video? Is it downloading the binaries?

On my system, in \AppData\Local\Programs\bible-karaoke\binaries, there
was only one file, ffprobe.exe.

I downloaded
https://ffmpeg.zeranoe.com/builds/win64/static/ffmpeg-4.2.2-win64-static.zip
(linked from ffmpeg.org) and copied ffmpeg.exe from the zip to the
binaries folder.

Now the BK generates the video successfully!

Not sure why ffmpeg.exe is missing in the binaries folder?

W

@megahirt
Copy link
Collaborator Author

megahirt commented Mar 5, 2020

From W:

From my testing, it does seem to be downloading ffmpeg on the fly.

When I turn off the wifi, delete the binaries folder, and click Make My Video, it creates the folder but ffprobe.exe does not appear. After turning on wifi and re-running the same test, ffprobe.exe appears. Seem to be some race conditions between the downloading of ffprobe.exe and clicking Make My Video. The first time Make My Video is clicked, this error appears:

Uh-oh!
Looks like something went wrong.
Details
Error trying to read audio length

Clicking Make My Video again gets past this but eventually still fails since ffmpeg.exe is not downloaded successfully.

W

@megahirt megahirt changed the title Error combining audio and video FFMPEG not properly downloading in application Mar 5, 2020
@megahirt megahirt added this to 0.4.0 in Bible Karaoke v1 Mar 7, 2020
@megahirt megahirt added this to the 0.3.5 milestone Mar 7, 2020
@megahirt megahirt moved this from 0.3.5 to 0.3.1 bugfix in Bible Karaoke v1 Mar 12, 2020
@megahirt megahirt modified the milestones: 0.3.5, 0.3.1 Mar 12, 2020
@megahirt megahirt moved this from 0.3.1 bugfix to Done in Bible Karaoke v1 Apr 20, 2020
@megahirt
Copy link
Collaborator Author

closing as finished in 0.3.1

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
Development

No branches or pull requests

1 participant