Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Flatpak FieldWorks GHA #357

Draft
wants to merge 15 commits into
base: develop
Choose a base branch
from
Draft

Add Flatpak FieldWorks GHA #357

wants to merge 15 commits into from

Conversation

marksvc
Copy link
Contributor

@marksvc marksvc commented Nov 22, 2021

This change is Reviewable

@ermshiperete
Copy link
Member

I find it surprising to have a GHA that builds FieldWorks in the flexbridge repo. Wouldn't it be better to do it in the FieldWorks repo? I'd think it should be possible to do even though the FW changes go through Gerrit since we mirror the repo to GH.

@marksvc
Copy link
Contributor Author

marksvc commented Nov 23, 2021

The Flatpak package for FieldWorks depends on a number of different included components, one of which is Flexbridge. It will be useful to know if a change to Flexbridge is going to break or continue working in the FieldWorks Flatpak package-build. (Tho we might not choose for that to be a blocking failure on a Flexbridge PR.)

This GHA is intended to build the FieldWorks Flatpak package, but with the proposed Flexbridge changes, showing what will happen if we later instruct the Flatpak package to use these new Flexbridge commits.

Yes it is probably an odd GHA to see :-). But that's the thinking. What do you think about that? Maybe it's not clear enough that the point of the GHA is to check the impact of the Flexbridge changes on the FW Flatpak package-build?

I do have a pre-merge build for proposed FieldWorks changes, that operates similarly to this GHA but that checks the proposed FieldWorks commit.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants