Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

liblcm: make the feature/nuget branch the main development branch #1014

Closed
4 of 5 tasks
ermshiperete opened this issue Dec 1, 2020 · 1 comment
Closed
4 of 5 tasks
Assignees
Labels
Milestone

Comments

@ermshiperete
Copy link
Member

ermshiperete commented Dec 1, 2020

  • merge master into feature/nuget again
  • announce that the merge of the feature/nuget branch will be made the main development branch
  • create a git tag on master (pre-nuget ?) before doing the merge
  • merge feature/nuget into master. Doing this requires adjusting the path to the CHANGELOG.md file in the .csproj as well as adjusting GitVersion.yml (removing settings for feature/nuget branch).
  • create a release of the nuget packages, and use these released nuget packages in the other projects.
@ermshiperete ermshiperete added this to the Nuget Sprint milestone Dec 1, 2020
@ermshiperete ermshiperete added this to To do in NuGet Package Sprint via automation Dec 1, 2020
@ermshiperete ermshiperete changed the title liblcm: merge master into feature/nuget liblcm: make the feature/nuget branch the main development branch Dec 1, 2020
@tombogle tombogle moved this from To do to In progress in NuGet Package Sprint Dec 7, 2020
@tombogle tombogle self-assigned this Dec 7, 2020
@tombogle
Copy link
Contributor

tombogle commented Dec 7, 2020

The PR represents my attempt at merging master into feature/nuget: sillsdev/liblcm#164
I was getting three test failures on my local machine, but it looks like two of them were red herrings. The third - which is a test I changed to get it to build - appears to be a new failure on the CI build. Probably someone more familiar with this project and this test should look at it and figure out the correct solution. With the WS test failure happening in libpalaso, it's entirely possible that this failure here is actually a consequence of whatever has gone wrong there, so maybe fixing this issue will set things right.

@ermshiperete ermshiperete moved this from In progress to Done in NuGet Package Sprint Nov 10, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
No open projects
Development

No branches or pull requests

2 participants